chore: add defrag logic for zsets #3836
Open
+132
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kostas <[email protected]>
Signed-off-by: kostas <[email protected]>
kostasrim
commented
Sep 30, 2024
| return realloced; | ||
| } | ||
|
|
||
| pair<sds, bool> ScoreMap::ReallocIfNeeded(void* obj, float ratio) { |
There was a problem hiding this comment.
I can extra this to seperate function. It's almost identical as to StringMap... I will follow up on this on separate PR with a small refactor
kostasrim
commented
Sep 30, 2024
|
|
||
| for (auto it = score_map->begin(); it != score_map->end(); ++it) { | ||
| realloced |= it.ReallocIfNeeded(ratio); | ||
| // Not sure if it's worth going over B+ tree cause lgn to delete + lgn to insert |
There was a problem hiding this comment.
Yeah, I don't think it's really worth going over the B+ tree because we would need to delete + insert. We can add this in the future if we wish to + it's really boilerplate....
kostasrim
commented
Sep 30, 2024
| @@ -142,4 +142,50 @@ detail::SdsScorePair ScoreMap::iterator::BreakToPair(void* obj) { | |||
| return detail::SdsScorePair(f, GetValue(f)); | |||
| } | |||
|
|
|||
| bool ScoreMap::iterator::ReallocIfNeeded(float ratio) { | |||
There was a problem hiding this comment.
Also //todo for me, mock this and test for sanity
kostasrim
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partially resolves #3822 [2/2]